We've moved discussions to Discord

Make Github Action checks pass after Jumpstart initialization

Pierre-Loïc
Hi there,

Just configured my new Jumpstart Pro and noticed that I got this error on the GitHub Action:
Standardrb Check
shell: /bin/bash -e {0} 

Run bundle exec standardrb 
bundle exec standardrb 
shell: /bin/bash -e {0} 
standard: Use Ruby Standard Style (https://github.com/testdouble/standard) 
standard: Run `standardrb --fix` to automatically fix some problems. 
 config/jumpstart/Gemfile:1:5: Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. 
 config/jumpstart/Gemfile:1:14: Layout/TrailingEmptyLines: Final newline missing. 


Notice: Disagree with these rules? While StandardRB is pre-1.0.0, feel free to submit suggestions to: 
 https://github.com/testdouble/standard/issues/new 
##[error]Process completed with exit code 1.

My Gemfile consists only in the Sidekiq gem. As stated, changing the quotes to double quotes and adding a final newline make this check pass.

Then, my tests were not passing because of an ArgumentError: key must be 16 bytes. To fix this, as discussed here, I just needed to add the proper secret on GitHub.
=> Repository Settings => Secrets => New secret => RAILS_MASTER_KEY and I chose the test.key value.

Problem solved!
Chris Oliver
👍

Standardrb is great for keeping consistency in your code formatting and I think the new RAILS_MASTER_KEY env var that was introduced in 5.2 trips up just about everyone at some point. 😜
Clement Camin
I had the issue too today (same problem: missing RAILS_MASTER_KEY), so that's at least 3 of us.

I can open a PR to add a documentation page about the available CI (standardrb, tests, system tests) and the already present GitHub action, what do you think ?

I didn't notice the GitHub action was there until I received a notification about it being broken, but after browsing a bit the forum I was aware the master key was a frequent issue so I knew what to look for.
Notifications
You’re not receiving notifications from this thread.